Andromeda/rust-http-server
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Correctly return files of the correct type #1

New Issue
Closed
opened 2025-06-19 11:09:09 +00:00 by Andromeda · 1 comment
Andromeda commented 2025-06-19 11:09:09 +00:00
Owner
Copy Link

set the content-type response header appropriately based on a) file extension and b) Accept request header. Currently the blog is broken because the css is returned as text/plain!

set the content-type response header appropriately based on a) file extension and b) Accept request header. Currently [the blog](https://blog.mtgmonkey.net) is broken because the css is returned as text/plain!
Andromeda added the
Kind/Bug
Priority
Critical
 labels 2025-06-19 11:43:52 +00:00
Andromeda commented 2025-06-19 14:02:05 +00:00
Author
Owner
Copy Link

Pull request d214b0bf86 fixed this issue, recognising text/javascript, text/css, text/html, image/png, and image/jpeg automatically based on file extensions and setting the Content-Type header accordingly. Otherwise, the Content-Type header is not set and is left to MIME sniffing or whatever on the browser side or on the part of a reverse proxy a user may be using (ferron, nginx, caddy, etc.)

Pull request d214b0bf8646ee7f2f0792bbf3b96db8dacc2468 fixed this issue, recognising text/javascript, text/css, text/html, image/png, and image/jpeg automatically based on file extensions and setting the Content-Type header accordingly. Otherwise, the Content-Type header is not set and is left to MIME sniffing or whatever on the browser side or on the part of a reverse proxy a user may be using (ferron, nginx, caddy, etc.)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Kind/Bug
Priority
Critical
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Andromeda
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Andromeda/rust-http-server#1
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?