range check char length

2026-03-18 16:21:34 +01:00
parent 17a0a1a406
commit de60e52c5a
2 changed files with 12 additions and 2 deletions
--- a/twasm/asm/main.asm
+++ b/twasm/asm/main.asm
@@ -866,7 +866,8 @@ evaluate_constant:
    jmp .bin_loop

  .chr:
-    ; TODO range check rcx
+    cmp rcx, 4       ; ensure char is only 4 bytes long
+    jg .unrecognised
    cmp rsi, 1 ; range check
    je .chr_break

@@ -896,7 +897,7 @@ evaluate_constant:
    jmp .chr_break

  .chr_break_for_good:
-    mov dl, [rdi]
+    mov dl, [rdi] ; make sure the chr is closed
    cmp dl, '"'
    jne .unrecognised